[Econ] Gallic Navy/GNI/Royalist Pilots are a hot mess

[Lord Caedus]

Type: Commodity
Bug: Gallic Navy/GNI/Royalist Pilots are a cluster.

Reproduction Steps:

• Get scanned by a GNI ship while on your GNI ship and naturally scan it back, thus seeing that it has a Gallic Navy (commodity_ganavy) pilot.
  
• Think that is odd, but not terribly stange as the GNI is a relatively recent addition, and click on the Gallic Navy pilot, which shows that it is (according to its infocard) actually a Confederal Navy pilot.
  
• Go and scan a Gallic Navy ship, it also uses this same "Navy but actually Confederal" pilot.
  
• Go look at darkstat for more information, such as if there even is a GNI pilot that should be on GNI ships. Darkstat helpfully tells us that there are in fact OCI pilots (commodity_council), which is the old Council Intelligence group, and these should be renamed to GNI pilots (and placed on GNI ships) which will need an infocard update.
  
• Also notice that Royalist Pilot (commodity_enclave) are using the infocard for the Gallic Navy pilot and that this needs to be fixed.
  
• While taking in-game screenshots as more direct evidence of all of this, notice that none of these pilots have their correct uniforms, and their commodity icons would need to be updated.
  
• Also notice that neither the Gallic Navy or currently unused OCI (which should become GNI pilots) actually have any value assigned to them, which means they don't sell for anything.
  
• Feel bad for Krmloo because he has to fix this massive mess.
  

Additional Information:

Spoiler

---

[Alex.]

Off the back of this report I have written a script which has found some very silly NPC pilots, such as Wild and Wendigo ships carrying Molly Pilots, and DSE ships carrying Red Hessian Pilots. I will try to clean this up a bit.

---

FLHook suggestions
All other dev queries
Please only PM me through the forums for things that need to be private like anticheat etc.

[Alex.]

As for this specific mess:

• We could introduce a separate GNI Pilot to stop them having to use GN Pilots, but we'd have to do the same for the MND/D-16, who use RM pilots. I'm not sure about re-using OCI pilots - possibly. There is an unused MND pilot commodity named for the Rheinland Federalists we could re-use on the Rheinland side of things...
  
• We should fix the Gallic Navy Pilot infocard talking about the Confederal Navy. done
  
• We should fix the Royalist Pilots using the Gallic Navy Pilot infocard. done
  
• We should fix the icons to the extent possible with existing icons - any new icons will need generation by someone else.
  
• We should fix the lack of value given to pilots. I notice LSF pilots have a default price of $15 credits. It looks like they do have value - disregard Darkstat on this matter, check in game values.
  

---

FLHook suggestions
All other dev queries
Please only PM me through the forums for things that need to be private like anticheat etc.