PoB Siege Mechanics

[Laz]

Ok, so I have to be gone very soon so I'll make this quick. I'll be honest when I say I fucked up. So in my rework what I am saying is true, but I didn't realise it was not true on the reverse. I sent the base repair code to @Its Raisu a few weeks ago explaining what everyone else thinks vs what it actually does and he agreed with me on why it doesn't do that (which was also wrong). The result was me not looking at the code and actually realising how it actually works until a few minutes ago. An unintentional flaw if ever there was one.

It was only after I had drafted up an entire thing about explaining how it works that I realised I had actually made such a glaring mistake. There is one word missing from the old base code that is present in mine.

"break;"

This one line that is missing from the current plugin causes it to loop over the code more times than it actually should, causing this behaviour of more commodities = more repairs. You all have my apologise for such a mistake, know it was not my intention. Turns out it was a simple bug I overlooked when updating the repair values. I did write up all the code explanation, if it's still wanted I can post it, but it does in fact prove I was wrong and simply overlooked it entirely. With that all being said, I have noticed some very janky mechanics about the old PoB system about when it actually decides to conduct more than a single repair. If the rework wasn't around the corner, I'd look into it a lot more.

With my idiocy out of the way, let's get back to the matter at hand concerning new siege mechanics and how PoBs should progress in the future. Provided an idea is good and approved I am willing to implement it, so I appreciate all the oddball ideas you guys are throwing this way.

And again, sorry.

---