• Home
  • Index
  • Search
  • Download
  • Server Rules
  • House Roleplay Laws
  • Player Utilities
  • Player Help
  • Forum Utilities
  • Returning Player?
  • Toggle Sidebar
Interactive Nav-Map
Tutorials
New Wiki
ID reference
Restart reference
Players Online
Player Activity
Faction Activity
Player Base Status
Discord Help Channel
DarkStat
Server public configs
POB Administration
Missing Powerplant
Stuck in Connecticut
Account Banned
Lost Ship/Account
POB Restoration
Disconnected
Member List
Forum Stats
Show Team
View New Posts
View Today's Posts
Calendar
Help
Archive Mode




Hi there Guest,  
Existing user?   Sign in    Create account
Login
Username:
Password: Lost Password?
 
  Discovery Gaming Community Discovery Development Discovery Developers Forum Discovery Unofficial Development Discovery Mod FLHook Projects
1 2 Next »
[FLHook] Docking Module plugin, rise from your grave

Server Time (24h)

Players Online

Active Events - Scoreboard

Latest activity

[FLHook] Docking Module plugin, rise from your grave
Offline Laz
06-09-2019, 06:31 PM,
#2
Out-of Retirement Code Monkey
Posts: 1,912
Threads: 107
Joined: Jan 2014

Solid work. I feel it's worth pointing out, the infinite jump bug has never been reproduced outside the live server. Something to add as well, and I know this isn't you but more a problem with the original plugin (and all plugins made by Cannon for that matter), but you might want to adjust the hardcoded values. There are a lot of them littered throughout the plugin, and if any of them don't exist it'll cause a server/client crash.

(i'm going to keep editing this as I think of more things to add)

I would have personally checked up with devs before posting this, because if it doesn't work (and I doubt it fixes the infinite jump bug if I'm being truly honest), it gives people false hope. Even after I've stopped doing dev work I am still asked to rewrite this plugin at least once a week (I don't even see the appeal in it tbh).

You've changed some of the returncodes to nofunctioncall and this will cause plugin conflicts. You really shouldn't do that unless you are absolutely sure the action wont be used in more than once place. I.e. the dock_call function call could have a massive fit if someone tries to dock while having a pending request. LaunchPosHook can bug up with PoBs since they both use the same structure as the temp ship store.

Looking at your code, you are creating new threads. You need to do proper thread management if you go down the route of multi-threaded behaviour because this code would absolutely not scale well. Like, I really need to stress that. You need to properly terminate your threads and not create one inside a for loop! Small scale, threads work quite well and it's difficult to see where errors may appear. But I'm reasonably confident, looking at your code, that this would scale horrible on the live server, given how many threads you are creating, and how you are just letting them run, rather than properly identifying, segregating, detaching, and terminating them.

Reply  


Messages In This Thread
[FLHook] Docking Module plugin, rise from your grave - by Invoker - 06-09-2019, 06:26 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Laz - 06-09-2019, 06:31 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Invoker - 06-09-2019, 08:24 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Kauket - 06-09-2019, 06:32 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Angela Williams - 06-09-2019, 06:38 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Skorak - 06-09-2019, 06:38 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by sasapinjic - 06-09-2019, 08:45 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Invoker - 06-09-2019, 10:52 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Its Raisu - 06-09-2019, 11:05 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Invoker - 06-11-2019, 12:10 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Durandal - 06-11-2019, 12:24 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by evanz - 06-11-2019, 12:30 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Fiendflug - 06-11-2019, 01:49 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Durandal - 06-11-2019, 02:00 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Rantari - 06-11-2019, 02:42 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Durandal - 06-11-2019, 04:50 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by eigos - 06-11-2019, 03:45 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Invoker - 06-12-2019, 11:49 AM
RE: [FLHook] Docking Module plugin, rise from your grave - by Alex. - 06-13-2019, 09:42 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Alley - 06-14-2019, 04:41 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Fiendflug - 06-14-2019, 05:06 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Banned player t202085 - 06-22-2019, 01:34 PM
RE: [FLHook] Docking Module plugin, rise from your grave - by Karlotta - 06-23-2019, 12:24 AM
RE: [FLHook] Docking Module plugin, rise from your grave - by Invoker - 06-23-2019, 09:35 AM
RE: [FLHook] Docking Module plugin, rise from your grave - by Mr.Jamison - 10-06-2023, 09:28 PM

  • View a Printable Version
  • Subscribe to this thread


Users browsing this thread:
1 Guest(s)



Powered By MyBB, © 2002-2026 MyBB Group. Theme © 2014 iAndrew & DiscoveryGC
  • Contact Us
  •  Lite mode
Linear Mode
Threaded Mode