4.92 Bug Reports

[Wildkins]

====================
Type: DSLauncher
Bug: Export of accounts incorrectly assigns description to the name field.
====================

TL;DR of the bug: When you export an account from DSLauncher, the name field of an account is overwritten with the description field. Here's an example:


Making a new account.


The account in the launcher.


The raw XML of the exported account, including the incorrectly set innerText of the XML.


The account, now imported, with the incorrect name field.

When accounts are exported in DSLauncher, the data is stored in an xml document which is made up of multiple xml elements, each containing account information, including the description, category, and key for each account. The name itself is stored as the innerText of the xml element.

However, a typo in the export dialogue (found under Forms/Primary.cs of the launcher build, line 1028) incorrectly assigns the innerText to be the 1st value of the account rows, which is the description of the account, not the name. The name is correctly found as the 0th cell of the account rows. By changing this value (line 1064) from 1 to 0 as seen below, the bug is resolved.



Once changed, this correctly sets the XML element's innerText to the name value saved in the launcher, which means newly exported accounts will have the name set properly. This was tested on DSLauncher 2.2.2 and merged with the release of DSLauncher 2.2.3. You can find more information about the pull request that fixes this issue here:
https://github.com/LazDisco/DSLauncher/pull/2

Thank you.

Thank you for this (possibly overdone) report, and providing a patch. I've rolled it out now so people should see this bug fixed next time they restart their launcher. ~Alex

---

RP Feedback