Freelancer Companion update for DiscoveryGC (Current: v4.32)

[Its Raisu]

https://i.imgur.com/3hroNVb.png

Short story on the crash I was able to identify:
It was possible for the Max Investment setting to set the number of units to 0 for some of the calculations that later occurred when generating the trade solutions. This caused a divide by zero error which is fixed in v4.32.

More detailed bit, for anyone interested in code bs

Line 1 calculates the number of units based on cargo size setting.
Line 2 and 3 ends processing for that trade if the number of units is 0.
Line 4 and 5 recalculates the number of units based on maxinvestment setting if it isn't enough to cover a full cargo load.

Line 4 and 5 can result in the number of units being set to 0. Which, as you see in Line 2 and 3, we should immediately end processing for.
Later in the function, "units" is used in "profit / units" or, in the case of what was causing the crash, "profit / 0"

This was fixed by swapping Line 2 and 3 and Line 4 and 5 so that each instance of "units" being 0 is handled properly.

Before:

Code:

    UINT units = m_cargoSize == 1 ? 1 : UINT(m_cargoSize/g_goods[goodIndex].m_volume);
    if (units == 0)
        return;
    if ((m_maxInvestment > 0) && (srcsell*units > m_maxInvestment))
        units = UINT(m_maxInvestment/srcsell);

<snip>

FLOAT calcCSU = (profit / units / g_goods[goodIndex].m_volume) * 100000 / distance;

After:

Code:

    UINT units = m_cargoSize == 1 ? 1 : UINT(m_cargoSize/g_goods[goodIndex].m_volume);
    if ((m_maxInvestment > 0) && (srcsell*units > m_maxInvestment))
        units = UINT(m_maxInvestment/srcsell);
    if (units == 0)
        return;

<snip>

FLOAT calcCSU = (profit / units / g_goods[goodIndex].m_volume) * 100000 / distance;

This was a mix of how FLCompanion was originally coded, and the addition of always utilizing the CSU calculation rather than only calculating it when Cargo Size was set to 1.