[Coding] Scanned by own NPC faction

[rwx]

Type: Coding
Bug: RFP players get scanned by Rheinland Federal Police NPCs

- Fixed: FactionScan.DLL should now be functional (each faction has a list of exempt factions that they won't scan, including players affiliated with those groups - see DATA/MISSIONS/faction_scan.ini).

Additional Information: https://imgur.com/a/9sJxGKm

[Alex.]

Reproduced this through `/restart rhpolice` and `.addcargo char commodity_cardamine 70` then flying about.
It's not obvious why through reading faction_scan.ini - there is this block:

[FactionScan]
faction = rh_mnd_grp ;MND
faction = rh_p_grp ;Rheinland Federal Police
faction = rh_n_grp ;Rheinland Military
dont_scan = rh_d19_grp ;Detachment 16
dont_scan = rh_mnd_grp ;MND
dont_scan = rh_p_grp ;Rheinland Federal Police

adoxa's FactionScan.cpp suggests this is a valid configuration.

---

FLHook suggestions
All other dev queries
Please only PM me through the forums for things that need to be private like anticheat etc.

[Alex.]

I've been debugging this and speaking with @rwx, right now I believe FactionScan is totally misconfigured for the following factions: BPA, BAF, GNI, Gendarmerie, KNF, KSP, LN, MND, and RFP. I believe this is due to FactionScan blocks containing multiple "faction =" lines in the config.
It is also partially broken for RM and LPI, due to those factions appearing twice in the config.

---

FLHook suggestions
All other dev queries
Please only PM me through the forums for things that need to be private like anticheat etc.

[Alex.]

Fix awaiting release

---

FLHook suggestions
All other dev queries
Please only PM me through the forums for things that need to be private like anticheat etc.